Handle prebuildify and node-pre-gyp, don't invoke prebuild-install for packages that don't use prebuild-install
#80
Unanswered
segevfiner
asked this question in
Q&A
Replies: 1 comment 1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
It would be nice if pkg handled packages using
prebuildify
,node-pre-gyp
andprebuild-install
better:prebuild-install
ornode-pre-gyp
if actually supported and used by the package or there is custom configuration where custom prebuilt binaries have been built for a package that doesn't otherwise have them, otherwise it will just error, output a warning/error for unhandled.node
files that are for the wrong platform. (For unsupported packages, users can place the right.node
files themselves ATM, so it can still work even if unsupported directly bypkg
).prebuildify
and package only the binaries for the right platform, it currently packages all of them, which can increate binary size significantly, and there is not per target ignore mechanism to workaround it currently. It should also try to correctly package needed additional vendored DLLs that are used by the.node
module, e.g. are alongside it, and only the ones for the correct platform.node-pre-gyp
packages.Beta Was this translation helpful? Give feedback.
All reactions