Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Superfluous memory allocations in fragmentation_t #206

Open
TheRandomCharacter opened this issue Jun 7, 2024 · 0 comments
Open

Superfluous memory allocations in fragmentation_t #206

TheRandomCharacter opened this issue Jun 7, 2024 · 0 comments

Comments

@TheRandomCharacter
Copy link
Collaborator

yanet/dataplane/fragmentation.cpp

Lines 161 to 164 in 87748d7

void fragmentation_t::handle()
{
std::vector<fragmentation::key_t> gc_keys;

It would be better to reuse same vector, instead of constructing and growing it every handle() call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheRandomCharacter