Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for Enhancing YANET's ACL Counters Feature #163

Open
saushew opened this issue Apr 11, 2024 · 0 comments
Open

Proposal for Enhancing YANET's ACL Counters Feature #163

saushew opened this issue Apr 11, 2024 · 0 comments

Comments

@saushew
Copy link
Collaborator

saushew commented Apr 11, 2024

In YANET, we currently have support for counters on each rule (a.k.a. acl counters). However, due to the packet firewall rule lookup happening 'top-down' (yes, our ruleset lookup is constant time, but during compilation, a structure is reproduced as if the packet honestly traverses the ruleset), these acl counters have a significant drawback:

Consider the scenario where we have rule1 and rule2; rule2 intersects with rule1 by mask, and rule1 is positioned higher in the ruleset than rule2.

If a packet passing through the firewall falls into the intersection of masks, it will terminate at rule1, and the acl counters will only be increased for this rule. Consequently, false positive conclusions may arise, indicating that the rule2 is inactive. We aim to avoid this.

Proposed Solution:
Introduce rules of the form add count from IPFW with a slight enhancement: append the counter name to the count separated by a colon.
Example: add count:counter_name <proto> from <src> to <dst>

This enhancement would provide a more accurate reflection of the active rules and prevent misleading interpretations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant