Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors #1

Closed
iviejo opened this issue Nov 30, 2022 · 3 comments
Closed

Errors #1

iviejo opened this issue Nov 30, 2022 · 3 comments

Comments

@iviejo
Copy link

iviejo commented Nov 30, 2022

The code has serveral errors:

  • It is only valid for grid points =5
  • Implicit solver not take into account te
  • ...
@yahya-ansariii
Copy link
Owner

Thanks for pointing out the errors, will check and update.
Could you specify the line number in code?

@iviejo
Copy link
Author

iviejo commented Dec 5, 2022

To be valid for different discretization the line:
df = pd.DataFrame(columns=["Node: 1", "Node: 2",
"Node: 3", "Node: 4", "Node: 5"])

Should be:
header=[]
for i in range(n):
header.append("Node: %i" %i)
df = pd.DataFrame(columns=header)

For the other error, I have not clear because I don't know the details of TDMA implementation. Tha fact for the implicit method you could solve directly a linear solver problem Ax=b

@yahya-ansariii
Copy link
Owner

Fixed number of nodes issue. If any other errors are found feel free to open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants