Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

[bz5147315] ContextController cache never cleans up #13

Closed
add0n opened this issue Mar 30, 2012 · 0 comments
Closed

[bz5147315] ContextController cache never cleans up #13

add0n opened this issue Mar 30, 2012 · 0 comments
Labels
Milestone

Comments

@add0n
Copy link
Contributor

add0n commented Mar 30, 2012

Y instances are cached within the client controller context object by mojit instance guid so that many actions on the same controller can always occur on the same instance.

If all the views of a particular mojit controller are destroyed, that Y instance is never removed.

This is a possible memory leak.

Every time a mojit proxy's private _destroy() function is called, the client needs to do a check to see if there are any more mojit proxies that exist tied to that same instance guid. If not, it should notify the ControllerContext to clear the cache for that guid, and it should dereference the cached Y instance.

@ghost ghost assigned isao Apr 24, 2012
@ghost ghost assigned isao Sep 11, 2012
isao pushed a commit to isao/mojito that referenced this issue Sep 13, 2012
isao pushed a commit that referenced this issue Sep 24, 2012
fix issue #13 ContextController cache never cleans up
merging for 0.4.x users
@isao isao closed this as completed Nov 7, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants