From 4241154f5e88ad9f1d306c762869ee546778db19 Mon Sep 17 00:00:00 2001 From: Axel Howind Date: Fri, 3 Nov 2023 16:58:56 +0100 Subject: [PATCH] use System.lineSeparator() --- .../main/java/com/dua3/utility/logging/ConsoleHandler.java | 2 +- .../src/main/java/com/dua3/utility/logging/LogEntry.java | 6 +----- .../java/com/dua3/utility/logging/slf4j/LogEntrySlf4j.java | 1 - utility/src/main/java/com/dua3/utility/text/TextUtil.java | 2 +- 4 files changed, 3 insertions(+), 8 deletions(-) diff --git a/utility-logging/src/main/java/com/dua3/utility/logging/ConsoleHandler.java b/utility-logging/src/main/java/com/dua3/utility/logging/ConsoleHandler.java index 56476074..b0c84b55 100644 --- a/utility-logging/src/main/java/com/dua3/utility/logging/ConsoleHandler.java +++ b/utility-logging/src/main/java/com/dua3/utility/logging/ConsoleHandler.java @@ -13,7 +13,7 @@ * It handles log entries by writing them to the console. */ public class ConsoleHandler implements LogEntryHandler { - private static final String NEWLINE = "%n".formatted(); + private static final String NEWLINE = System.lineSeparator(); private final PrintStream out; private final Map> colorMap = new EnumMap<>(LogLevel.class); diff --git a/utility-logging/src/main/java/com/dua3/utility/logging/LogEntry.java b/utility-logging/src/main/java/com/dua3/utility/logging/LogEntry.java index 65d4e409..a1121f29 100644 --- a/utility-logging/src/main/java/com/dua3/utility/logging/LogEntry.java +++ b/utility-logging/src/main/java/com/dua3/utility/logging/LogEntry.java @@ -20,10 +20,6 @@ public interface LogEntry { Throwable throwable(); default String format(String prefix, String suffix) { - class Constants { - private static final char[] NEW_LINE = String.format("%n").toCharArray(); - }; - StringBuilder sb = new StringBuilder(100); sb.append(prefix); sb.append('[').append(level()).append(']'); @@ -34,7 +30,7 @@ class Constants { sb.append(' '); sb.append(message()); if (throwable() != null) { - sb.append(Constants.NEW_LINE); + sb.append(System.lineSeparator()); appendThrowable(sb); } sb.append(suffix); diff --git a/utility-logging/utility-logging-slf4j/src/main/java/com/dua3/utility/logging/slf4j/LogEntrySlf4j.java b/utility-logging/utility-logging-slf4j/src/main/java/com/dua3/utility/logging/slf4j/LogEntrySlf4j.java index e1930f80..e9ebff18 100644 --- a/utility-logging/utility-logging-slf4j/src/main/java/com/dua3/utility/logging/slf4j/LogEntrySlf4j.java +++ b/utility-logging/utility-logging-slf4j/src/main/java/com/dua3/utility/logging/slf4j/LogEntrySlf4j.java @@ -17,7 +17,6 @@ * Represents a log entry with information about the log message, time, level, logger, and optional marker and throwable. */ public final class LogEntrySlf4j implements LogEntry { - private static final char[] NEW_LINE = String.format("%n").toCharArray(); private final String loggerName; private final Instant time; private final LogLevel level; diff --git a/utility/src/main/java/com/dua3/utility/text/TextUtil.java b/utility/src/main/java/com/dua3/utility/text/TextUtil.java index 9891aeb3..4ee16a4b 100644 --- a/utility/src/main/java/com/dua3/utility/text/TextUtil.java +++ b/utility/src/main/java/com/dua3/utility/text/TextUtil.java @@ -35,7 +35,7 @@ public final class TextUtil { /** * The current system's end-of-line sequence. */ - public static final String LINE_END_SYSTEM = String.format("%n"); + public static final String LINE_END_SYSTEM = System.lineSeparator(); /** * UNIX end-of-line sequence. */