From 682c7c80cc10336ce8f7b69a8b5cce685dc96900 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcin=20Krzemin=CC=81ski?= Date: Sat, 21 Dec 2024 18:24:14 +0100 Subject: [PATCH 1/2] Add data type check with fallback --- connectors/class-connector-wordpress-seo.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/connectors/class-connector-wordpress-seo.php b/connectors/class-connector-wordpress-seo.php index 7c52a0864..eb839d599 100644 --- a/connectors/class-connector-wordpress-seo.php +++ b/connectors/class-connector-wordpress-seo.php @@ -413,7 +413,10 @@ private function meta( $object_id, $meta_key, $meta_value ) { } $post = get_post( $object_id ); - $post_type_label = get_post_type_labels( get_post_type_object( $post->post_type ) )->singular_name; + $post_type_obj = get_post_type_object( $post->post_type ); + $post_type_label = is_object( $post_type_obj ) && isset( $post_type_obj->labels->singular_name ) + ? $post_type_obj->labels->singular_name + : $post->post_type; $this->log( sprintf( From 62039e5128401afcf34358d56537899f8d4ea012 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcin=20Krzemin=CC=81ski?= Date: Sat, 21 Dec 2024 18:25:02 +0100 Subject: [PATCH 2/2] Cast string for data provided tp log message --- connectors/class-connector-wordpress-seo.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/connectors/class-connector-wordpress-seo.php b/connectors/class-connector-wordpress-seo.php index eb839d599..5b12ef508 100644 --- a/connectors/class-connector-wordpress-seo.php +++ b/connectors/class-connector-wordpress-seo.php @@ -422,9 +422,9 @@ private function meta( $object_id, $meta_key, $meta_value ) { sprintf( /* translators: %1$s: a meta field title, %2$s: a post title, %3$s: a post type (e.g. "Description", "Hello World", "Post") */ __( 'Updated "%1$s" of "%2$s" %3$s', 'stream' ), - $this->escape_percentages( $field['title'] ), - $this->escape_percentages( $post->post_title ), - $this->escape_percentages( $post_type_label ) + $this->escape_percentages( (string) $field['title'] ), + $this->escape_percentages( (string) $post->post_title ), + $this->escape_percentages( (string) $post_type_label ) ), array( 'meta_key' => $meta_key,