Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate problems with vertically offset glyphs on some fonts #5257

Open
Tyriar opened this issue Dec 19, 2024 · 0 comments
Open

Re-evaluate problems with vertically offset glyphs on some fonts #5257

Tyriar opened this issue Dec 19, 2024 · 0 comments
Labels

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 19, 2024

There's a workaround in VS Code to tweak the default fonts used in the terminal as the font metrics always seemed to be a little wrong, shifting the font down such that underscores wouldn't show among other problems:

https://github.com/microsoft/vscode/blob/05519998aeb60a492478948e6e196586a24c04c6/src/vs/workbench/contrib/terminal/browser/terminalConfigurationService.ts#L114-L125

Another issue has come up with Source Code Pro, SauceCodePro Nerd Font in microsoft/vscode#204591 that shows a similar problem. We should look into how we calculate the bounding box in webgl and dive a little deeper into this problem:

  • Would moving to TextMetrics solve these problems over the current approach?
  • What textBaseline are we using and can we move to alphabetical?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant