From ea4e02887a766bd53ce98ca88510c1edba1efc55 Mon Sep 17 00:00:00 2001 From: Kevin Robatel Date: Fri, 3 Nov 2023 08:56:31 +0000 Subject: [PATCH] Fix text after list --- lib/reverse_markdown/converters/ol.rb | 2 +- reverse_markdown.gemspec | 2 +- spec/assets/lists.html | 5 +++++ spec/components/lists_spec.rb | 3 +++ spec/lib/reverse_markdown_spec.rb | 2 +- spec/spec_helper.rb | 2 +- 6 files changed, 12 insertions(+), 4 deletions(-) diff --git a/lib/reverse_markdown/converters/ol.rb b/lib/reverse_markdown/converters/ol.rb index 10395c5..2fa3a02 100644 --- a/lib/reverse_markdown/converters/ol.rb +++ b/lib/reverse_markdown/converters/ol.rb @@ -3,7 +3,7 @@ module Converters class Ol < Base def convert(node, state = {}) ol_count = state.fetch(:ol_count, 0) + 1 - "\n" << treat_children(node, state.merge(ol_count: ol_count)) + "\n" << treat_children(node, state.merge(ol_count: ol_count)) << "\n" end end diff --git a/reverse_markdown.gemspec b/reverse_markdown.gemspec index 432191f..970e93d 100644 --- a/reverse_markdown.gemspec +++ b/reverse_markdown.gemspec @@ -23,6 +23,6 @@ Gem::Specification.new do |s| s.add_development_dependency 'simplecov' s.add_development_dependency 'rake' s.add_development_dependency 'kramdown' - s.add_development_dependency 'byebug' + s.add_development_dependency 'debug' s.add_development_dependency 'codeclimate-test-reporter' end diff --git a/spec/assets/lists.html b/spec/assets/lists.html index 8a2ba9e..007f825 100644 --- a/spec/assets/lists.html +++ b/spec/assets/lists.html @@ -95,5 +95,10 @@
  • delta
  • + + text after the list + diff --git a/spec/components/lists_spec.rb b/spec/components/lists_spec.rb index 629cb0d..dab5481 100644 --- a/spec/components/lists_spec.rb +++ b/spec/components/lists_spec.rb @@ -65,4 +65,7 @@ it { is_expected.to match /\n- delta\n/ } end + context "text following list should have a new line separator" do + it { is_expected.to match /\n- item followed with a text\n\n text after the list/ } + end end diff --git a/spec/lib/reverse_markdown_spec.rb b/spec/lib/reverse_markdown_spec.rb index 6efc3d3..ef5b416 100644 --- a/spec/lib/reverse_markdown_spec.rb +++ b/spec/lib/reverse_markdown_spec.rb @@ -36,7 +36,7 @@ describe 'force_encoding option', jruby: :exclude do it 'raises invalid byte sequence in UTF-8 exception' do - expect { ReverseMarkdown.convert("hi \255") }.to raise_error(ArgumentError) + expect { ReverseMarkdown.convert("hi \255") }.to raise_error(Encoding::CompatibilityError) end it 'handles invalid byte sequence if option is set' do diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 4a82e9c..9cf5a54 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,5 +1,5 @@ require 'simplecov' -# require 'byebug' +require 'debug' SimpleCov.profiles.define 'gem' do add_filter '/spec/'