Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set u+w on the sites/default directory for cleanup. #14

Open
pearcec opened this issue Dec 20, 2012 · 2 comments
Open

Set u+w on the sites/default directory for cleanup. #14

pearcec opened this issue Dec 20, 2012 · 2 comments

Comments

@pearcec
Copy link

pearcec commented Dec 20, 2012

#10 - issuecomment-11558213

Drupal sets the sites/default to r-x for the user. This has the adverse side effect of making the cleanup job fail. As David noted if you blanket set the entire release directory with u+w you can remove the current release. This works, but I think we need to be a bit more surgical. If there is something else that is set wrong, I would want to see it and have drush-deploy fail so we can inspect what happened.
@pearcec pearcec mentioned this issue Dec 20, 2012
Open
@pearcec
Copy link
Author

pearcec commented Dec 20, 2012

The cleanup code is a bit more involved. There isn't a specific variable that is referenced. It puts together a list of directories to whack. This is done using local variables. So we need to do the same. Ugly but it will work.

@pearcec pearcec mentioned this issue Dec 20, 2012
Closed
@pearcec
Copy link
Author

pearcec commented Dec 20, 2012

I take back my original comment about being surgical. See my commit comment for a further explanation.

pearcec pushed a commit that referenced this issue Jan 19, 2013
Fix permission on sites/default and settings.php during cleanup
93a52c3 
Drupal removes write permission on the sites/default directory and settings.php
file.  When drush-deploy goes to clean it up it fails leaving dirty releases
hanging out.  The simple approach is to set the permission back prior to clean
up.  I choose to blanket set the user permsions to write (u+w) for the entire
release directory.  I felt it wasn't necessary to be specifically cautious
because the next task is to simply rm -rf the directory.  The point is to ditch
it.

This patch is an effort to clean up issue #14.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pearcec