Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write useful tests #18

Open
chengsun opened this issue Jan 7, 2015 · 0 comments
Open

Write useful tests #18

chengsun opened this issue Jan 7, 2015 · 0 comments

Comments

@chengsun
Copy link
Contributor

chengsun commented Jan 7, 2015

Think about how to do tests that actually test something.

We still need to write a test for each step. These should ideally assert that the XMLRPC requests made are as we expect them to be.

An idea could be to create a mock RPC client object that also satisfies the RPC interface

type RPCMockClient struct {...}
func (c *RPCMockClient) Call(method string, params interface{}, result interface{}) error {...}

This would take a whole bunch of effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant