From 2d96ac146e61c46efc89fdcc5a957d650335443f Mon Sep 17 00:00:00 2001
From: Spirin Vladimir <spirin.vladimir@gmail.com>
Date: Thu, 12 Aug 2021 01:30:34 +0200
Subject: [PATCH] tiny refactoring

cons: duplicate code `_move(src, dst, amt);`
props: remove extra check `msg.sender != src`
---
 contracts/XPToken.sol | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/contracts/XPToken.sol b/contracts/XPToken.sol
index 2108bc7..4320e21 100644
--- a/contracts/XPToken.sol
+++ b/contracts/XPToken.sol
@@ -91,16 +91,20 @@ contract XPToken is XTokenBase, IERC20, XApollo {
         address dst,
         uint256 amt
     ) external returns (bool) {
-        require(
-            msg.sender == src || amt <= _allowance[src][msg.sender],
-            "ERR_BTOKEN_BAD_CALLER"
-        );
-        _move(src, dst, amt);
-        if (msg.sender != src && _allowance[src][msg.sender] != uint256(-1)) {
-            _allowance[src][msg.sender] = (_allowance[src][msg.sender]).bsub(
-                amt
+        if (msg.sender == src) {
+            _move(src, dst, amt);
+        } else {
+            require(
+                amt <= _allowance[src][msg.sender],
+                "ERR_BTOKEN_BAD_CALLER"
             );
-            emit Approval(msg.sender, dst, _allowance[src][msg.sender]);
+            _move(src, dst, amt);
+            if (_allowance[src][msg.sender] != uint256(-1)) {
+                _allowance[src][msg.sender] = (_allowance[src][msg.sender]).bsub(
+                    amt
+                );
+                emit Approval(msg.sender, dst, _allowance[src][msg.sender]);
+            }
         }
         return true;
     }