Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subs loaded as episodes #86

Open
bluboyo opened this issue Apr 27, 2020 · 24 comments
Open

Subs loaded as episodes #86

bluboyo opened this issue Apr 27, 2020 · 24 comments

Comments

@bluboyo
Copy link

bluboyo commented Apr 27, 2020

New bug now when it works with the library. I use 18.7 nightly and 2.3.1 Works very nice but the subs folder is read as an epside two times. So one episide for the first rar, then the same again for the rar inside the rar. So now I have Three episodes inside kodi when there is a seperate subsfolder in rar.

@amazingdash
Copy link

This looks like the problem I mentioned here: #68 (comment)

I just tested with 2.3.1 and I still get .subfiles added to my tv shows library. From the scan log:

VideoInfoScanner: Adding new item to tvshows:rar://rar%3a%2f%2f%252f[...]%252fSubs%252f[...].subs.rar%2f[...].rar/[...].sub

If I URL-decode the path twice, I get this:

rar://rar://path/to/directory/Subs/episode.subs.rar/episode.rar/episode.sub

Non-nested rars are fine (the .sub doesn't get added to the library).

@amazingdash
Copy link

@faltaren ugly workaround that seems to work:

<advancedsettings version="1.0">
  <video>
    <excludetvshowsfromscan>
      <regexp>\.sub$</regexp>
    <excludetvshowsfromscan>
  <video>
</advancedsettings>

@bluboyo
Copy link
Author

bluboyo commented Apr 27, 2020

Were do i paste this?

@amazingdash
Copy link

@bluboyo
Copy link
Author

bluboyo commented Apr 28, 2020

Will try. Thx :)

@bluboyo
Copy link
Author

bluboyo commented Apr 29, 2020

Didnt work :(. Did a total rescan of the show (removed and readded) and it still scans the subs as episodes.

@Sopor
Copy link
Contributor

Sopor commented Apr 29, 2020

@faltaren What is the name of the subs?

This is regex and \.sub$ means that the file need to end with .sub. Maybe it is better is you exclude the subs folder.

Try use this instead <regexp>(?i)[\\/]subs[\\/]</regexp>

@bluboyo
Copy link
Author

bluboyo commented Apr 30, 2020

Noop. Still the same. Removed, readded. Clean. Nothing...

@bluboyo
Copy link
Author

bluboyo commented May 1, 2020

@AlwinEsch are you working on this? Really anoying to have 3 of every ep 😫

@AlwinEsch
Copy link
Member

I look soon to fix it, was shortly on another project.

@bluboyo
Copy link
Author

bluboyo commented May 2, 2020

Thx 😊

@Sopor
Copy link
Contributor

Sopor commented May 3, 2020

@faltaren How do you have your subtitles?
I did a test here with Kodi 18.6 and 18.7 (compiled 2020-05-02) and vfs.rar 2.3.1 and i have no problems at all.
I have a Subs folder where the sub files are in a RAR file.
This was movies but it is hard to find TV episodes that have external subtitles. Most of them have the subtitles in the video file.

@bluboyo
Copy link
Author

bluboyo commented May 4, 2020

Its folder in the episode that is named subs. Then rar and sfv file

@Sopor
Copy link
Contributor

Sopor commented May 4, 2020

Yeah, same as me then, but i only tried it on movies and it seems to work for me.

@Sopor
Copy link
Contributor

Sopor commented May 4, 2020

Yes, now i manage to get TV shows to create not three but at least two of every episodes. I even tried exclude Subs as i asked you to try, but i still get two of every episodes.

In my case both the subs files are compressed in best even the rar inside the rar.

@Sopor
Copy link
Contributor

Sopor commented May 4, 2020

It seems that both these will be ignored when scanning RAR files

        <excludefromscan action="append">
          <regexp>(?i)[\\/]proof|subs|sample[\\/]</regexp>
        </excludefromscan>
         <excludefromlisting action="append">
          <regexp>(?i)[\\/](proof|subs|sample)[\\/]</regexp>
        </excludefromlisting>

@bluboyo
Copy link
Author

bluboyo commented May 5, 2020

You see 😋

@amazingdash
Copy link

I look soon to fix it, was shortly on another project.

@AlwinEsch hey, sorry to bother you but have you had any time to reproduce/fix this? Kodi 18.7 has been released and it did nothing for this specific issue.

@AlwinEsch
Copy link
Member

Think this becomes no more fixed inside Leia, there comes now 18.8 and if nothing special come, then the last release and then only becomes fixed in Kodi 19.0 Matrix.

@bluboyo
Copy link
Author

bluboyo commented Jul 23, 2020

Ok. Sounds fine 😊

@bluboyo
Copy link
Author

bluboyo commented Jul 30, 2020

If there was a fix for this in 18.8 i didnt work. Removed everything and rescanned. Still double/tripple eps.

@AlwinEsch
Copy link
Member

See my note before:

Think this becomes no more fixed inside Leia, there comes now 18.8 and if nothing special come, then the last release and then only becomes fixed in Kodi 19.0 Matrix.

On Leia was no time anymore on his last release to add, only within Matrix I can look about.

@bluboyo
Copy link
Author

bluboyo commented Jul 30, 2020

Aha så "Fixes subtitle handling from archives" is something else

@kraaa
Copy link

kraaa commented Aug 5, 2020

xbmc/xbmc#18232
Might have a temp solution. One guy got it fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants