Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COBieLiteUK: Conversion from IFC sets Address lines equal to .NET Type Name #18

Open
MichaelBuehler opened this issue Mar 1, 2017 · 4 comments

Comments

@MichaelBuehler
Copy link

On conversion from IFC2x3 or IFC4, the Contact street will be set to .NET Type Name.

From XML export
Xbim.Ifc4.OptionalItemSet`1[Xbim.Ifc4.MeasureResource.IfcLabel]

Probably there is no .ToString() implementation for ItemSet as code assumes:

MappingIfcActorToContact.cs Line 87 and 145
target.Street = postal.AddressLines != null && postal.AddressLines.Any() ? string.Join(", ", postal.AddressLines) : null;

Using version on NuGET: Essentials 4.0.15 and Exchange 4.0.4.

@Jero9999
Copy link

I am also getting this one

@CBenghi
Copy link
Member

CBenghi commented Apr 18, 2017

Hello @Jero9999,
I'm having problem following this thread. The current codebase is 4.0.6-V0005 using Essentials 4.0.28-V017, does the error still apply?
A test file would help.
Claudio

@Jero9999
Copy link

Jero9999 commented May 2, 2017

The unit test you wrote for issue 17 (#17) shows this issue as well.

@CBenghi
Copy link
Member

CBenghi commented May 3, 2017

Hello @Jero9999,
investigating this I've found issues in Essentials, I'll fix this as soon as the essentials bug is gone.
Thanks,
Claudio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants