Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binning in LOS projection step should be in pixel space #88

Open
wtbarnes opened this issue Oct 13, 2023 · 0 comments
Open

Binning in LOS projection step should be in pixel space #88

wtbarnes opened this issue Oct 13, 2023 · 0 comments

Comments

@wtbarnes
Copy link
Owner

Currently, when projecting coordinates down to the detector, the binning of the emission is done in world coordinate space using the helioprojective coordinates. Instead, the binning should just be done in pixel space.

This will require refactoring some of the logic around how the header is computed. Currently, the number of bins and bin range are computed in world space using the coordinates of all of the loops and then this is used to compute the header. Instead, the extent of the image would need to be worked out separately, then the header constructed from that estimated extent. A WCS could then be derived from that header from which the pixel coordinates could be worked out. This would also simplify the calling sequence for LOS projection function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant