-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ioneq
with ionization_fraction
and add setter
#337
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
==========================================
- Coverage 90.96% 90.61% -0.36%
==========================================
Files 41 41
Lines 3399 3432 +33
==========================================
+ Hits 3092 3110 +18
- Misses 307 322 +15 ☔ View full report in Codecov by Sentry. |
@wtbarnes, how were the |
The fiasco/fiasco/tests/idl/helpers.py Lines 127 to 129 in b74ecc0
That being said, I do not think it is necessary to remove the usage of "ioneq" when it is in the context of the IDL results as that is what the quantity is called in the IDL code. I would actually prefer to preserve that nomenclature in that context. As such, any reference to "ioneq" in the tests when referring to the IDL results can be left as is. All of the test files can also remain unchanged, both in name and their contents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions regarding how the setter is handled and some docstring modifications. Thanks as always for taking this on.
This is a breaking change to the API, but I'm not so worried about that at this stage.
Co-authored-by: Will Barnes <[email protected]>
Co-authored-by: Will Barnes <[email protected]>
Co-authored-by: Will Barnes <[email protected]>
Co-authored-by: Will Barnes <[email protected]>
Co-authored-by: Will Barnes <[email protected]>
Fixes #324
Fixes #326
Also fixes a minor bug introduced by #332 that was breaking
generate_hash_tables
because the path to the hash tables changed.