-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differing behavior on two different systems #304
Comments
That's really odd. I just built a fresh environment using the versions you list above (on an Apple M1 Macbook Pro) and I get an answer that is the same (up to numerical precision) with your first result. This is also the answer I would expect given the formation temperatures of the O ions. A few things to try:
oxygen = fiasco.Element('O',1e5*u.K)
for ion in oxygen:
print(ion.recombination_rate)
print(ion.ionization_rate) If both of you still get the same answer, then the actual solution to the ionization equilibria is behaving differently which is more worrying. |
We'll try using an identical database file between our systems, will let you know. Another puzzling thing is we get identical results to each other (to floating point accuracy) if we change oxygen to carbon or iron. |
That is even more puzzling! If you loop over all elements ( |
With fiasco.version = 0.2.3, numpy.version = 1.24.3, astropy.version=6.0.1, python 3.11 i get the following output for creating an oxygen element for 1e5K which seems reasonable:
but my student running exactly the same thing with the same set of versions above gets a fully neutral result for the same input. Is there anything I'm not checking to ensure things are set up identically?
The text was updated successfully, but these errors were encountered: