Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid URL #1

Open
jcubic opened this issue Jan 22, 2024 · 0 comments
Open

Invalid URL #1

jcubic opened this issue Jan 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jcubic
Copy link

jcubic commented Jan 22, 2024

The action doesn't work. Give an error about an Invalid URL. No stack trace nothing.

Expected Behavior

I expect the Action to purge all images in the README

Current Behavior

It gives error

purging: https://github.com/jcubic/velvet/blob/master/README.md
Error: TypeError [ERR_INVALID_URL]: Invalid URL
Error: Invalid URL

Link to repo

https://github.com/jcubic/velvet

Possible solution

The issue is that README can contain normal noncached images added with HTML. Only Markdown images are cached.

So there is a need to check if img.attribs['data-canonical-src'] exists otherwise PURGE HTTP request with throw an error.

@jcubic jcubic added the bug Something isn't working label Jan 22, 2024
jcubic added a commit to jcubic/purge-readme that referenced this issue Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant