Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RtL support for draw_text_attachment_to_canvas #279

Open
momo-ozawa opened this issue Jun 22, 2021 · 0 comments
Open

Add RtL support for draw_text_attachment_to_canvas #279

momo-ozawa opened this issue Jun 22, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@momo-ozawa
Copy link

Description

Text alignment for screenshot overlay text must be flipped for RtL languages.

Background Context

Ref: wordpress-mobile/WordPress-iOS#16707

While adding the ar-SA (Arabic) and he (Hebrew) locales to screenshot generation, I realized that the overlay text alignment needs to to be flipped for RtL languages.

In the Jetpack app, the splash image has text that's left-aligned for LtR languages, which needs to be flipped to be right-aligned for RtL languages.

JP

iPhone XS Max-0-Splash iPhone XS Max-1-MySite iPhone XS Max-2-ActivityLog iPhone XS Max-3-JetpackScan iPhone XS Max-4-JetpackBackup iPhone XS Max-5-Stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant