[FE] 중복 선언된 alert 제거 #317
Merged
[FE] 중복 선언된 alert 제거 #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Largopie
added
🐈 프론트엔드
Test Results4 tests 4 ✅ 3s ⏱️ Results for commit cafd05a. ♻️ This comment has been updated with latest results. |
Yoonkyoungme
approved these changes
Aug 22, 2024
hw0603
force-pushed
the
fix/316-logout-alert
branch
from
e8c078e to
cafd05a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
로그아웃 시, alert가 두번 출력되는 현상 해결
=> 원인 : user mutation 레이어 분리 시, 해당 alert를 중복해서 선언했습니다. 따라서 mutation에 있는 alert를 유지하고 Header의 alert를 제거했습니다.
특이 사항
현재 alert는 UI로직인데 서버 상태관리 로직인 useMutation의 onSuccess 내부에서 사용되고 있는데, 추후 수정이 필요합니다.
중복 선언된 alert 제거
리뷰 요구사항 (선택)