Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Final release produces a Prerelease on when publish Github Release #74

Open
Larusso opened this issue Sep 2, 2021 · 1 comment
Open
Assignees

Comments

@Larusso
Copy link
Member

Larusso commented Sep 2, 2021

Description

When executing a final release for a WDK project the actual github release is marked as prerelease.
I checked the code and it looks like we changed the check values during the gradle upgrade process.
Currently we check for project.status != 'final'.
as seen here:

githubPublishTask.prerelease.set(project.provider { project.status != 'final' })

The old code did check
githubPublishTask.setPrerelease({ project.status != 'release' })

We need to fix this and maybe provide a test case to verify this.

@Azurelol
Copy link
Contributor

Azurelol commented Sep 2, 2021

Should it then check for (not final OR not release)?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants