From d5f1a64dcc454734a59d5e8a1b30cb388ab1f5b8 Mon Sep 17 00:00:00 2001 From: nullterminated Date: Wed, 13 Feb 2013 19:12:23 -0700 Subject: [PATCH] Deprecated broken methods --- .../Sources/er/extensions/net/ERXEmailValidator.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Frameworks/Core/ERExtensions/Sources/er/extensions/net/ERXEmailValidator.java b/Frameworks/Core/ERExtensions/Sources/er/extensions/net/ERXEmailValidator.java index b38cb19ef98..6fb31742d70 100644 --- a/Frameworks/Core/ERExtensions/Sources/er/extensions/net/ERXEmailValidator.java +++ b/Frameworks/Core/ERExtensions/Sources/er/extensions/net/ERXEmailValidator.java @@ -222,6 +222,10 @@ public Boolean call() { * @return true if the hostName is valid, false if no hostName or MX record * is found, null if lookup times out * @throws NamingException + * + * @deprecated this method will throw mysterious NullPointerExceptions if used + * in a loop. Evidently, something about the DirContext is not as thread safe + * as the javadocs claim. Do not use it. */ public static Boolean isValidDomainString(String hostName, long timeout) { if (timeout < 1) { @@ -262,11 +266,13 @@ public static Boolean isValidDomainString(String hostName, long timeout) { * @param def * default value if timeout occurs * @return true if the email passes both validations + * + * @deprecated Deprecated because it relies on {@link ERXEmailValidator#isValidDomainString(String, long)} */ public boolean isValidEmailAddress(String email, long timeout, boolean def) { if (isValidEmailString(email)) { String hostName = hostNameForEmailString(email); - Boolean value = isValidDomainString(hostName, timeout); + Boolean value = ERXEmailValidator.isValidDomainString(hostName, timeout); return ERXValueUtilities.booleanValueWithDefault(value, def); } return false;