block: console warning "Invalid Morebits.date initialisation" when picking certain durations such as 3 hours

[NovemLinguae]

Steps to reproduce

• be an admin
• visit a test user's talk page
• open the block module
• have DevTools console open
• select 3 hours for block duration
• submit

What happens?

• Invalid Morebits.date initialisation: ['3 hours']

What should have happened instead?

• No console warning

Notes

• First seen when using the block module and selecting 3 hours as the block duration. Doesn't appear to cause any bugs, but throws this console warning before the page refreshes.
• Not a result of recent refactorings. Still happens using a commit from a month ago.

[siddharthvp]

Well, '3 hours' is an invalid date, so the warning is correct. It results in NaN if you try to retrieve any time elements.

[NovemLinguae]

Looks like I should refocus this ticket on the block module rather than the morebits library. Done.

Looks like the block module is trying to initialize a relative time (3 hours) rather than an absolute time (December 21, 2024 @ 6AM) like it's supposed to.