Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Able to submit invalid regex exclusion #2227

Closed
SuaYoo opened this issue Dec 10, 2024 · 2 comments · Fixed by #2228 or #2316
Closed

[Bug]: Able to submit invalid regex exclusion #2227

SuaYoo opened this issue Dec 10, 2024 · 2 comments · Fixed by #2228 or #2316
Assignees
@ikreymer @SuaYoo @tw4l
Labels
back end Requires back end dev work bug Something isn't working front end Requires front end dev work

Comments

@SuaYoo
Copy link
Member

SuaYoo commented Dec 10, 2024 •
edited
Loading

Browsertrix Version

v1.13.0-beta.0-fe2ea9c

What did you expect to happen? What happened instead?

Upon entering an invalid regex like **, the validation error message is correctly shown. However, I can still submit it by hitting Enter on the keyboard.

Reproduction instructions

  1. Log in as crawler
  2. Start a crawl
  3. Go to watch crawl
  4. Open exclusion editor
  5. Choose "Regex" type
  6. Type in invalid regex like **. Observe that although error message is shown, you can still submit it by hitting "enter" on your keyboard.

Screenshots / Video

No response

Environment

No response

Additional details

The backend should also validate the regular expression.
@SuaYoo SuaYoo added bug Something isn't working front end Requires front end dev work labels Dec 10, 2024
@SuaYoo SuaYoo self-assigned this Dec 10, 2024
@SuaYoo SuaYoo moved this from Todo to Implementing in Webrecorder Projects Dec 10, 2024
@SuaYoo SuaYoo moved this from Implementing to In Review in Webrecorder Projects Dec 10, 2024
@SuaYoo SuaYoo mentioned this issue Dec 10, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Review to Done! in Webrecorder Projects Dec 10, 2024
@ikreymer
Copy link
Member

There's still a variation of this when starting a new crawl / from workflow editor.

  1. Add a new exclusion as 'Match Text' in workflow editor
  2. Enter '**'
  3. Switch to Regex mode -- the invalid string '**' is not treated as a regex
  4. Save (with invalid exclusion regex)

@ikreymer ikreymer reopened this Dec 10, 2024
@github-project-automation github-project-automation bot moved this from Done! to Todo in Webrecorder Projects Dec 10, 2024
@SuaYoo SuaYoo moved this from Todo to Ready in Webrecorder Projects Dec 11, 2024
@SuaYoo SuaYoo added the back end Requires back end dev work label Dec 11, 2024
@ikreymer ikreymer moved this from Ready to Todo in Webrecorder Projects Dec 11, 2024
@tw4l tw4l self-assigned this Jan 8, 2025
@tw4l
Copy link
Member

tw4l commented Jan 8, 2025

To do: Backend validation of regexes

@SuaYoo SuaYoo moved this from Todo to Ready in Webrecorder Projects Jan 13, 2025
@tw4l tw4l mentioned this issue Jan 16, 2025
Merged
@tw4l tw4l moved this from Ready to Implementing in Webrecorder Projects Jan 16, 2025
@tw4l tw4l moved this from Implementing to In Review in Webrecorder Projects Jan 16, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done! in Webrecorder Projects Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikreymer ikreymer

@SuaYoo SuaYoo

@tw4l tw4l

Labels
back end Requires back end dev work bug Something isn't working front end Requires front end dev work
Projects
Webrecorder Projects
Status: Done!
Milestone
No milestone
3 participants
@ikreymer @SuaYoo @tw4l