Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Collection replay should be fully updated when an item is added or removed #2175

Closed
ikreymer opened this issue Nov 23, 2024 · 1 comment
Closed

[Bug]: Collection replay should be fully updated when an item is added or removed #2175

ikreymer opened this issue Nov 23, 2024 · 1 comment
Assignees
@ikreymer
Labels
bug Something isn't working

Comments

@ikreymer
Copy link
Member

Browsertrix Version

v1.12.0

What did you expect to happen? What happened instead?

The replay cache is not currently cleared when an item is added / removed, resulting in replay not being up to date with state of collection.

Reproduction instructions

  1. Create collection, add items
  2. Load replay.
  3. Remove items, add other items
  4. Observe replay is not automatically updated.

Screenshots / Video

No response

Environment

No response

Additional details

The simplest solution is to do a full reload, which will be supported via webrecorder/replayweb.page#374
@ikreymer ikreymer added the bug Something isn't working label Nov 23, 2024
@ikreymer ikreymer self-assigned this Nov 23, 2024
@ikreymer ikreymer moved this from Triage to Todo in Webrecorder Projects Nov 23, 2024
@ikreymer ikreymer moved this from Todo to In Review in Webrecorder Projects Nov 23, 2024
@ikreymer ikreymer moved this from In Review to Todo in Webrecorder Projects Nov 23, 2024
@ikreymer ikreymer mentioned this issue Nov 23, 2024
Merged
ikreymer added a commit that referenced this issue Nov 23, 2024
@ikreymer
ensure collection replay is fully reload (cache cleared) when: (#2176)
070a833 
- editing collection metadata
- adding / remove collection items
- storages: don't default to 'use_access_for_presign' to true, fixes
support for custom CDN on DigitalOcean
- fixes missing string 'Removing X items from collection', was not
wrapped in msg()
- fixes #2175
@Shrinks99
Copy link
Member

Fixed in #2176

@github-project-automation github-project-automation bot moved this from Todo to Done! in Webrecorder Projects Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikreymer ikreymer

Labels
bug Something isn't working
Projects
Webrecorder Projects
Status: Done!
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ikreymer @Shrinks99