From a860f3bee0f0c23461759e009149d36377c894ad Mon Sep 17 00:00:00 2001 From: Ian Kilpatrick Date: Thu, 3 Oct 2024 13:43:22 -0700 Subject: [PATCH] [flex] Fix line cross-size calculation with extreme baselines. As pointed out in: https://github.com/WebKit/WebKit/pull/31376#discussion_r1782062028 Blink/WebKit were doing something incorrect when a baseline was outside the border-box of a flex-item. This was because we were initializing max_major_descent and max_minor_descent to zero, instead of LayoutUnit::Min(), (similar to FlexLine::max_major_ascent_ FlexLine::max_minor_ascent_). This only occurs with a single item in a flex-line. Change-Id: I4f32eb912a07247d16231451ba63e7c7a75a8b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901280 Commit-Queue: Ian Kilpatrick Reviewed-by: David Grogan Cr-Commit-Position: refs/heads/main@{#1363827} --- css/css-flexbox/baseline-outside-flex-item.html | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 css/css-flexbox/baseline-outside-flex-item.html diff --git a/css/css-flexbox/baseline-outside-flex-item.html b/css/css-flexbox/baseline-outside-flex-item.html new file mode 100644 index 00000000000000..feb1930df46b6b --- /dev/null +++ b/css/css-flexbox/baseline-outside-flex-item.html @@ -0,0 +1,10 @@ + + + +A baseline outside a single flex-item shouldn't affect the size of the flex-line. +

Test passes if there is a filled green square and no red.

+
+
+
baseline
+
+