Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add missing findBundle option to ensure test cases are executed #9057

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haocheng6
Copy link
Contributor

Summary

Partially fixes #9056.

The findBundle option also needs to be added to a few other test cases, but those tests are a bit more tricky to fix. See #9056.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 206ae0f
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/678edeac1d79650008330bf9

@haocheng6 haocheng6 changed the title Add missing findBundle option to ensure test cases are executed fix: add missing findBundle option to ensure test cases are executed Jan 20, 2025
Copy link

codspeed-hq bot commented Jan 20, 2025

CodSpeed Performance Report

Merging #9057 will not alter performance

Comparing haocheng6:fix/9056-add-test-configs (206ae0f) with main (c06787b)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@hardfist hardfist requested a review from stormslowly January 22, 2025 03:45
@chenjiahan chenjiahan changed the title fix: add missing findBundle option to ensure test cases are executed test: add missing findBundle option to ensure test cases are executed Jan 23, 2025
@chenjiahan
Copy link
Member

@stormslowly cc~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Some tests are not executed because the findBundle option is not overriden
2 participants