Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Vue coding style #31

Open
NingW101 opened this issue Nov 27, 2023 · 0 comments
Open

Unify Vue coding style #31

NingW101 opened this issue Nov 27, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@NingW101
Copy link
Contributor

As we are composition API with Single-File Components(SFC), <script setup> is strongly recommended for a more succinct and ergonomic syntax.

In the code base, most of vue components use SFC + <script setup> but there are still a few components that don't follow it. Although this does not affect functionality, it's better to modify them to achieve a unified coding style.

For example,

// <Footer.vue>
<script lang="ts">
import { defineComponent, reactive, toRefs, onMounted, watch } from "vue";
import { useRouter } from "vue-router";
import { NavItem } from "../common/types";

export default defineComponent({
  name: "FooterComp",

  setup() {}
});

Some references:

@NingW101 NingW101 added the good first issue Good for newcomers label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant