Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HelmRelease v2beta2 (flux 2.2.0) #4165

Closed
foot opened this issue Dec 12, 2023 · 4 comments · Fixed by #4374
Closed

Support for HelmRelease v2beta2 (flux 2.2.0) #4165

foot opened this issue Dec 12, 2023 · 4 comments · Fixed by #4374
Assignees
Labels
revalidation Check to see if this is still an issue after recent updates

Comments

@foot
Copy link
Contributor

foot commented Dec 12, 2023

In Flux 2.2.0 .status.lastReleaseRevision will be deprecated and no longer populated.

The code in weave-gitops should be adapted as in flux:

Anticipated behaviour:

  • weave-gitops 0.38.0 + flux 2.1.0 -- inventory of helmrelease shown correctly
  • weave-gitops 0.38.0 + flux 2.2.0 -- inventory not show or an error about not being able to read secret
  • weave-gitops 0.3x.x (upcoming release) + flux 2.1.0 -- inventory of helmrelease shown correctly
  • weave-gitops 0.3x.x (upcoming release) + flux 2.2.0 -- inventory of helmrelease shown correctly
@bigkevmcd
Copy link
Contributor

We need to figure out what fields we use, and where they've gone.

We also want to continue to support the existing version, and the new(er) versions, we want to avoid another version break.

@stefanprodan
Copy link
Collaborator

To support both versions, WG can look at the CRD version (this is already fetched in the Flux controllers page), based on the API version the query logic should use:

  • status.LastReleaseRevision v2beta1 / status.History.Latest().Version v2beta2
  • status.LastAppliedRevision v2beta1 / status.History.Latest().ChartVersion v2beta2

@hiddeco
Copy link
Contributor

hiddeco commented Dec 12, 2023

The deprecation notices in the v2beta2 API should actually tell you where to look for values, as will they correctly indicate fields have been deprecated in the more intelligent IDEs.

@bigkevmcd bigkevmcd self-assigned this Dec 12, 2023
@foot foot changed the title Support for HelmRelease v2beta2 Support for HelmRelease v2beta2 (flux 2.2.0) Dec 13, 2023
@casibbald casibbald added revalidation Check to see if this is still an issue after recent updates and removed team/pesto labels Jan 10, 2025
@erikgb
Copy link
Contributor

erikgb commented Jan 10, 2025

#4374 should have fixed this. We are focusing on supporting the latest version of Flux APIs for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revalidation Check to see if this is still an issue after recent updates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants