-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow supplying custom success, error handlers #10
Comments
I assume you know that you can just put the success handler on the landing-uri, and that you're suggesting an optimisation? |
Well a bit more than on optimization I guess. It's still going to do a redirect and expects a potential function to return a landing-uri. And on error, it just returns 400. |
Sure, but you could do all of those things from the landing-uri. The only thing a success handler gives you, as far as I can see, is that you get to perform actions before the redirect. |
Or even without a redirect. But yes, of course. |
#37 partially addresses this issue, but the limitation is that |
Currently, redirect handler forces redirecting to the landing-uri on success but I often like to do something with the newly gained access token right away, like fetch user details, (open) id, federating with local user account etc. Would you consider supporting optional custom handlers for each profile, e.g.
{:success-handler (fn [access-token] ...)}
?The text was updated successfully, but these errors were encountered: