-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always use the user's tsconfig.json
when processing their code
#2247
Comments
This is some nice, easy to understand analysis, love it! What did you use to make the diagrams? |
Users indirectly requesting this (they're requesting simpler imports or
I recall many similar requests, but we didn't record them. Still, I'm certain that the lack of support for import aliases is a common hurdle. |
Not quite finish, we did server and web-app in #2444, but still need to do the SDK. |
Note
This issue is related to #1718 but can be solved independently.
Problem
The user code is currently type-checked and built in four different contexts, each with its own errors and reporting.
See the table or graph below for details.
/tsconfig.json
.wasp/out/sdk/wasp/tsconfig.json
[Wasp]
wasp start
andwasp build
.wasp/out/server/tsconfig.json
[Server]
wasp build
*.wasp/out/web-app/tsconfig.json
[Webapp]
wasp build
* The server does not do any type-checking during
wasp compile
. See #2458 for details. The web app does (last updated for version 0.15.2).Solution
We should explore how to always process the user's code exclusively under the rules specified in their
tsconfig.json
. This is most likely doable with project references: #1827 (comment).We must do this for all three of our framework's modules (SDK, client, server), and I believe project references are a solution in all three cases.
The text was updated successfully, but these errors were encountered: