Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extjs console output on detection is just version number #6

Open
gingeleski opened this issue Apr 25, 2019 · 0 comments
Open

extjs console output on detection is just version number #6

gingeleski opened this issue Apr 25, 2019 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@gingeleski
Copy link
Member

Noticed on a recent engagement that target was using extjs but libreveal.js printed just the version number. In lieu of the expected libreveal.js: extjs @ <version here>

Quick glance looks like for whatever reason there's conditional logic in the console.log calls.

This issue covers investigation and fixing of the bug.
@gingeleski gingeleski added bug Something isn't working good first issue Good for newcomers labels Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gingeleski