-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version oddities #137
Comments
Hmm another case of some kind of custom version sorter would be nice #112? when i use Will think a bit more about this |
BTW i noticed the regex seem to produce duplicates, probably because of tags/ and head/ and also |
In this case i think #112 would do the correct thing? ➜ bump git:(version-sort) ✗ go run ./cmd/bump pipeline -v 'static:1.11.6,1.12.5p2,1.12.5|sort:version'
Parsed pipeline: static:1.11.6,1.12.5p2,1.12.5|sort:version
static:1.11.6,1.12.5p2,1.12.5:
1.11.6
1.12.5p2
1.12.5
@ name -> name
sort:version:
1.12.5p2
1.12.5
1.11.6
@ name -> name
value 1.12.5p2
1.12.5p2 Maybe we talked about it before, the You can play around with it using If useful maybe some filter like that could be added? maybe a better name? separate filter and not argument to |
Good news, I worked around it by finding another source of info - their website. # bump: poco-version /POCO_VERSION="(.*)"/ https://pocoproject.org/|re:/Latest.Release:.([\d.]+p?\d?)/$1/
POCO_VERSION="1.12.5p2"
export ZOPEN_DEV_URL="https://pocoproject.org/releases/poco-${POCO_VERSION}/poco-${POCO_VERSION}.tar.gz" |
I tried the version-sort branch and it works ok. go run github.com/wader/bump/cmd/bump@version-sort pipeline -v 'gitrefs:https://github.com/pocoproject/poco.git|re:#tags/poco-([\d.]+p?\d?)-release$#$1#|sort:version'
...
sort:version:
1.13.0:commit=fe3d9dba5b9a146dcb86929bfa102b742358be52
1.12.5p2:commit=e6c3d5821ff7e6f25d8dc20b116b81b073316147
1.12.5p1:commit=47bb4db5c61f5a5ac9a5ead2b65c9afc2a2e1228
1.12.5:commit=bbffa0fb3fb3668bce34cc7d9b40d21495cc754b
|
👍 yeap i've notice also sometimes that git tags show up a bit early sometimes 😄
Thanks for testing, do let me know if you run into similar cases that are hard to sort etc so we have more context and tests for a possible future filter |
Close? |
Yup, thanks as always for your help & for sharing your excellent, excellent work. |
🥳 |
Hey, more oddities I can't figure out.
Please help when you find time?
https://github.com/pocoproject/poco/releases
bump pipeline -v 'gitrefs:https://github.com/pocoproject/poco.git|re:/poco-([\d.]+p?\d?)-release/$1/'
Seems to be finding things other than
1.12.5p2
.The text was updated successfully, but these errors were encountered: