Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jam-types 0.1.8 ordering bug #30

Open
gilescope opened this issue Dec 19, 2024 · 0 comments
Open

jam-types 0.1.8 ordering bug #30

gilescope opened this issue Dec 19, 2024 · 0 comments

Comments

@gilescope
Copy link

In jam types 0.1.8, it's defined in this order:

#[derive(Copy, Clone, Encode, Decode, Debug, Eq, PartialEq)]
pub struct OpaqueValKeyset {
	/// The opaque Ed25519 public key.
	pub ed25519: OpaqueEd25519Public,
	/// The opaque Bandersnatch public key.
	pub bandersnatch: OpaqueBandersnatchPublic,
	/// The opaque BLS public key.
	pub bls: OpaqueBlsPublic,
	/// The opaque metadata.
	pub metadata: OpaqueValidatorMetadata,
}

but in

"bandersnatch": "0x5e465beb01dbafe160ce8216047f2155dd0569f058afd52dcea601025a8d161d",
and in the scale the bandersnatch comes first. The gray paper clearly states bandersnatch is first (6.9) so this seems a bug in jam types.

I would raise it there, but there seems no public repo associated with https://crates.io/crates/jam-types ? I raise it here as this is where people will notice the inconsistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant