Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need updates to artifacts/compatibility-yaml #157

Open
sashrith opened this issue Jul 13, 2022 · 1 comment
Open

Need updates to artifacts/compatibility-yaml #157

sashrith opened this issue Jul 13, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@sashrith
Copy link

Issue/Feature Description: Need updates for https://github.com/vmware-tanzu/vsphere-kubernetes-drivers-operator/blob/main/artifacts/compatibility-yaml/compatibility-v0.2.1.yaml

What type of Issue/Feature is this?
/kind bug fix

Why this fix/ feature is needed(give scenarios or use cases):
Some fixes are required for the compatibility yaml file

"2.5.1": {
      "vSphere": { "min": "6.7.1", "max": "7.0.4" },
      "k8s": { "min": "1.20", "max": "1.23" },
      "isCPIRequired": false,
      "deploymentPath": [
          "https://raw.githubusercontent.com/kubernetes-sigs/vsphere-csi-driver/v2.5.1/manifests/vanilla/vsphere-csi-driver.yaml" ]
    },

should be

"2.5.1": {
      "vSphere": { "min": "6.7.1", "max": "7.0.4" },
      "k8s": { "min": "1.21", "max": "1.23" },               <----
      "isCPIRequired": false,
      "deploymentPath": [
          "https://raw.githubusercontent.com/kubernetes-sigs/vsphere-csi-driver/v2.5.1/manifests/vanilla/vsphere-csi-driver.yaml" ]
    },

and vsphere version should be >6.7u3 for all CSI releases, not sure if "6.7.1" covers that correctly

CPI manifests should be taken from https://github.com/kubernetes/cloud-provider-vsphere/tree/master/releases//vsphere-cloud-controller-manager.yaml

CPI manifests from the following path are deprecated,
https://github.com/kubernetes/cloud-provider-vsphere/tree/master/manifests/controller-manager -

@asifdxtreme
Copy link
Collaborator

Thanks @sashrith for validating these yamls and compatibility-matrix, we will fix this soon or it would be great if you can send out a patch to update these yamls over here

@asifdxtreme asifdxtreme added the bug Something isn't working label Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants
@asifdxtreme @sashrith and others