Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to input cluster-distribution type in vsphere-config-secret for CSI 2.3 onwards #142

Open
rpanduranga opened this issue Jan 18, 2022 · 0 comments
Milestone

Comments

@rpanduranga
Copy link

rpanduranga commented Jan 18, 2022

Issue/Feature Description:
Add support to input cluster-distribution type in vsphere-config-secret for CSI 2.3 onwards

What type of Issue/Feature is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind enhancement

Why this fix/ feature is needed(give scenarios or use cases):
From CSI 2.3 onwards, and VC/ESX 7.0u2 CNS Analytics for vSphere is suppose to show the kind of the distribution the k8s is the metadata details of the PV.

here is the snippet from the requirement gathered in one pager

There should be an ability to find the different K8s distributions (Supervisor Cluster, TKG Guest Cluster, Ent.PKS, OpenShift, Google Anthos, upstream K8s) that are using PVs on CNS

CNS needs to store Kubernetes distribution info so that report statistics grouped by distributions

To support above requirement, CSI introduced the parameter that user have to update the csi-vsphere.conf file with the cluster-distribution

$ cat /etc/kubernetes/csi-vsphere.conf
[Global]
cluster-id = ""
cluster-distribution= "" # for example: PKS, TKG service, Anthos
...

As VDO handles the secret creation, it is expected the vsphere-config-secret should have these key

How to reproduce, in case of a bug:
Decoded the existing secret vsphere-config-secret to view the content.

[Global]
cluster-id = ""

[VirtualCenter ""]
insecure-flag = "true"
user = "[email protected]"
password = "Admin!23"
datacenters = "VSAN-DC"

Other Notes / Environment Information: (Please give the env information, log link or any useful information for this issue)
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/2.0/vmware-vsphere-csp-getting-started/GUID-BFF39F1D-F70A-4360-ABC9-85BDAFBE8864.html

@asifdxtreme asifdxtreme added this to the Sprint-6 milestone Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@asifdxtreme @rpanduranga and others