Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing interpolation of MARKETING_VERSION in a few places #41

Open
evictor opened this issue Jul 11, 2021 · 1 comment
Open

Missing interpolation of MARKETING_VERSION in a few places #41

evictor opened this issue Jul 11, 2021 · 1 comment

Comments

@evictor
Copy link

evictor commented Jul 11, 2021

I randomly saw the var substitution/str interpolation template in a few places when using the latest binary, alerter_v004_darwin_amd64.zip:

Finder "Info", Version metadata

image

Invoking cli without args

image

I didn't actually go looking for this, so it's possible there are other places where this var needs to be subbed.

@section83
Copy link

Thanks. Yes, Alerter was my first attempt to bundle someone else's code using Xcode. There is a lot to learn e.g. getting all the environment variables correct. As long as Alerter works in all versions of macOS from 10.13 on, I'm happy to wait and fix the issue in the future.

I bundled my own build of Alerter because version 4 doesn't work in High Sierra (at least on my old Mac Mini).

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants