Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brackets and Dark Mode #820

Open
curran opened this issue Aug 2, 2024 · 1 comment
Open

Brackets and Dark Mode #820

curran opened this issue Aug 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@curran
Copy link
Contributor

curran commented Aug 2, 2024

Feedback from someone who used VZCode in VizHub to give a live coding workshop:

went well! people loved it. some fun technical issues not only to do with Vizhub. the room was so bright i had to switch to light mode. but that made the brackets disappear too? anyway such a minor thing.

I think this may be to do with the rainbow brackets.

I feel like @michaelhelper you may have mentioned this earlier but I don't recall.

The first thing to do is to test the light mode / dark mode, then see if we can get the syntax highlighting to work well in both modes, including rainbow brackets.

One potential short term "fix" would be to disable rainbow brackets until we can get this resolved. Could do by putting the entire rainbow brackets feature behind a feature flag.

@curran curran added the bug Something isn't working label Sep 17, 2024
@curran
Copy link
Contributor Author

curran commented Sep 17, 2024

TODO drop screenshots of light mode vs. dark mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: RCOS Fall 2024
Development

No branches or pull requests

1 participant