Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Improvements #75

Closed
sauterl opened this issue May 27, 2024 · 7 comments
Closed

Build Improvements #75

sauterl opened this issue May 27, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@sauterl
Copy link
Contributor

sauterl commented May 27, 2024

Currently, the build includes JARS for all plattforms (for some of the dependencies), we should cleanup and optimise the build process to have more lean distributions.

@ppanopticon ppanopticon added the enhancement New feature or request label Jun 17, 2024
@ppanopticon ppanopticon added this to the Release Candidate #1 milestone Jun 17, 2024
@sauterl sauterl removed their assignment Jul 5, 2024
@sauterl
Copy link
Contributor Author

sauterl commented Jul 5, 2024

Removing myself from this issue due to time constraints. @faberf or @net-cscience-raphael , would you mind to have a look at this?

@faberf faberf self-assigned this Jul 22, 2024
@faberf
Copy link
Contributor

faberf commented Jul 22, 2024

Hey, I am inexperienced with this sort of thing, but I would like to try tackling this. Will look into this starting tomorrow.

@faberf
Copy link
Contributor

faberf commented Jul 30, 2024

@sauterl Hey, could you help me clarify what exactly the task involves? I'm not entirely sure what specific steps are required. Should I go through the different modules and check that there are no unused dependencies? I guess the Idea is that we need to make sure platform-specific dependencies are only included where necessary. Do you have any dependencies in mind specifically? Any guidance would be greatly appreciated. Thanks!

@sauterl
Copy link
Contributor Author

sauterl commented Jul 30, 2024

@faberf I am not sure anymore which ones in particular. To me, one way on finding out which dependencies are OS specific (and therefore should not be included always) is a build on one OS and then manually find non-OS specific jars in the lib folder (e.g. after a gradlew distZip)

@sauterl
Copy link
Contributor Author

sauterl commented Jul 30, 2024

Among others, tesseract, opencv, openblas are dependencies which have OS dependent JARs.

@ppanopticon
Copy link
Member

@faberf I have just cleaned-up the dependencies in the feature/3d-preview branch. Maybe this can act as an inspiration.

@net-cscience-raphael
Copy link
Contributor

see #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants