ScenegraphLayer getShaders() not working

[euzu]

I have subclassed ScreengraphLayer to use another vertex shader. I implemented the getShaders() method.
With the latest release this doesnt works anymore. Now i need to overwrite _getModelOptions() and set
.modelOptions.vs = myCustomShader.

Is this the desired behaviour ?

[Pessimistress]

Has that ever worked? AFAIK this layer never used getShaders

[euzu]

Yes it worked, i checked twice. i have a deployment with the previous version which uses the custom shader. I Updated he development environment to the latest version and the shader is ignore.

[Pessimistress]

What was the previous version you were using?

[euzu]

Regardless of the history, it should be possible to use custom shaders. The current implementation does not take getShaders() into account.
Should it stay that way ?

[Pessimistress]

Yes it should be fixed. I'm just trying to understand if this is a regression, as you implied in your original statement. If a regression happened in the current release, then we need to patch it in 8.3.x. If it never worked, then we'll likely address it in 8.4.0.

[euzu]

Sorry, I was mistaken.
I had overwritten the method getLoadOptions() and additionally getShaders(). Apparently getLoadOptions() was responsible for setting the custom shader. getShaders() was ignored.

[Pessimistress]

This is fixed in 8.4.0-alpha and will be in 8.4.0