Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home directory quota options are not logical in defaults for new users in this virtual server #997

Open
PitWenkin opened this issue Jan 15, 2025 · 10 comments

Comments

@PitWenkin
Copy link
Contributor

Short version:

The options Default (from template) and Unlimited are not doing what the labels suggest but what the respective other option suggests …

Details:

Under Server Template - Mail for domain I have set a quota of 50MiB for mail users

Screenshot 2025-01-15 at 10 22 42

In the domain specific setting for User Defaults the interface shows Home directory quota as Unlimited, but when adding a new mail user the 50MiB form the server template are applied, which should only happen when Default (from template) is selected?

Screenshot 2025-01-15 at 10 12 28

Selecting Default (from template) actually applies no quota …

Selecting the third option propperly applies the given quota.

@jcameron
Copy link
Collaborator

Thanks, that does look like a bug! Let me take a look ...

@jcameron
Copy link
Collaborator

Can you post the contents of the file /etc/webmin/virtual-server/initial/XYZ where XYZ is the domain's unique numeric ID? You can get that by running virtualmin list-domains --domain yourdomain.com --id-only

@PitWenkin
Copy link
Contributor Author

dbs=
shell=/dev/null
secs=
quota=none

While Interface shows

Image

@PitWenkin
Copy link
Contributor Author

I've had this on 2 servers, settings above are from my dev-machine, which might be fucked up, but behaves in the same way as the others.

My guess is that simply switching the labels for option 1 and 2 would "fix" it

@PitWenkin
Copy link
Contributor Author

When selecting Unlimited:

dbs=
shell=/dev/null
secs=

When selecting 25 Mib:

dbs=
shell=/dev/null
secs=
quota=25600

@jcameron
Copy link
Collaborator

Ok I see the bug now - this will be fixed in the next release.

webmin pushed a commit that referenced this issue Jan 16, 2025
@iliajie
Copy link
Collaborator

iliajie commented Jan 20, 2025

@PitWenkin Try applying the patch and see if it resolves the problem for you:

webmin patch https://github.com/virtualmin/virtualmin-gpl/commit/a4e5c37

@PitWenkin
Copy link
Contributor Author

@PitWenkin Try applying the patch and see if it resolves the problem for you:

webmin patch https://github.com/virtualmin/virtualmin-gpl/commit/a4e5c37

It's worse. I still had 25MB saved

dbs=
shell=/dev/null
secs=
quota=25600

but interface shows

Image

Even after saving it does not change …

@iliajie iliajie reopened this Jan 20, 2025
@iliajie
Copy link
Collaborator

iliajie commented Jan 20, 2025

Great! Thanks for giving it a try! Now we'll wait for Jamie's comment on this...

@jcameron
Copy link
Collaborator

Hmm, let me take another look at this..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants