Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add throwing error when unable to open file on iOS #135

Open
markholland opened this issue Jul 1, 2022 · 0 comments · May be fixed by #137
Open

Add throwing error when unable to open file on iOS #135

markholland opened this issue Jul 1, 2022 · 0 comments · May be fixed by #137

Comments

@markholland
Copy link

markholland commented Jul 1, 2022

We are migrating from rn-fetch-blob openDocument to this library for opening files from our app.

With this library, on Android if a file can't be opened an error is thrown but this isn't the case on iOS.

With rn-fetch-blob we did have this behaviour on iOS and would like to keep it.

Is there a reason why failing to open a file on iOS isn't considered as an error?

Here is the relevant code in rn-fetch-blob https://github.com/joltup/rn-fetch-blob/blob/master/ios/RNFetchBlob/RNFetchBlob.m#L610

Thanks in advance

@markholland markholland linked a pull request Jul 4, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant