Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aborted test script due to warnings #48

Open
jonknowles opened this issue Nov 27, 2019 · 3 comments
Open

Aborted test script due to warnings #48

jonknowles opened this issue Nov 27, 2019 · 3 comments

Comments

@jonknowles
Copy link

jonknowles commented Nov 27, 2019

I've cloned the repository and installed it successfully, but when I run npm run test I get the following error:

> [email protected] test C:\Users\jknowles\workspace\vtt.js
> grunt

Running "jshint:files" (jshint) task
Warning: The "path" argument must be of type string. Received type object Use --force to continue.

Aborted due to warnings.

I'm not very familiar with grunt build tools, but I've tried removing the jshint task by deleting "jshint" from the array on line 112 of ./Gruntfile.js. Running npm run test after that also fails, but it gets a bit further:

> [email protected] test C:\Users\jknowles\workspace\vtt.js
> grunt

Running "uglify:dev" (uglify) task
File dev_build/vtt.min.js created: 56.04 kB → 21.3 kB

Running "concat:dev" (concat) task
File dev_build/vtt.js created.

Running "mochaTest:test" (mochaTest) task
>> Mocha exploded!
>> TypeError: Cannot read property 'prototype' of undefined
>> at Object. (C:\Users\jknowles\workspace\vtt.js\node_modules\socket.io\lib\store.js:35:42)
>> at Module._compile (module.js:652:30)
>> at Object.Module._extensions..js (module.js:663:10)
>> at Module.load (module.js:565:32)
>> at tryModuleLoad (module.js:505:12)
>> at Function.Module._load (module.js:497:3)
>> at Module.require (module.js:596:17)
>> at require (internal/module.js:11:18)
>> at Object. (C:\Users\jknowles\workspace\vtt.js\node_modules\socket.io\lib\manager.js:15:13)
>> at Module._compile (module.js:652:30)
Warning: Task "mochaTest:test" failed. Use --force to continue.

Aborted due to warnings.

I've tried running this on node versions 8.11.2, 10.16.3, and 13.0.1, but none of those work. Are the tests supposed to be working for this project at the moment?

@gkatsev
Copy link
Member

gkatsev commented Nov 27, 2019

Unfortunately, the test scripts are broken and can only be run on node 0.10. I've been basically testing things manually as things are changing. I hope to revamp the test suite completely soon.

@jonknowles
Copy link
Author

Ah, that explains things. Thank you for the extremely prompt response!

@gkatsev
Copy link
Member

gkatsev commented Nov 27, 2019

You're welcome.
I'm actually in the middle of a refactor to move a bunch of things into separate files so it's a bit easier to work with this repo. Hopefully, afterwards I can start on updating tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants