Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use response files as command lines can get very long #18

Open
alexrp opened this issue Jun 23, 2021 · 5 comments
Open

Use response files as command lines can get very long #18

alexrp opened this issue Jun 23, 2021 · 5 comments
Assignees
@alexrp
Labels
area: tasks Issues related to MSBuild tasks. state: approved Enhancements and tasks that have been approved.
Milestone
Future

Comments

@alexrp
Copy link
Member

alexrp commented Jun 23, 2021

No description provided.

@alexrp alexrp added type: feature state: approved Enhancements and tasks that have been approved. area: tasks Issues related to MSBuild tasks. labels Jun 23, 2021
@alexrp alexrp self-assigned this Jun 23, 2021
@alexrp alexrp modified the milestones: 2.0.0, 2.0, 3.0 Jun 30, 2021
@alexrp
Copy link
Member Author

alexrp commented Jul 7, 2021

Running into some weird and inexplicable FileNotFound errors. Will need to investigate more and file a Zig bug. This probably won't make Zig 0.8.1, so changing milestone.

@alexrp alexrp modified the milestones: 3.0, 4.0 Jul 7, 2021
@alexrp
Copy link
Member Author

alexrp commented Jul 26, 2021 •
edited
Loading

See: ziglang/zig#9456 ziglang/zig#9654

@alexrp
Copy link
Member Author

alexrp commented Apr 7, 2022

The fix for this should be in Zig 0.10.0.

@alexrp alexrp modified the milestones: v4.0, v5.0, v4.1 Aug 4, 2023
@alexrp alexrp mentioned this issue Aug 4, 2023
Closed
@alexrp alexrp modified the milestones: v4.1, v4.2 Jan 2, 2024
@alexrp alexrp changed the title Use response files for C/C++ compilation as the command lines can get very long Use response files as command lines can get very long Jan 4, 2024
@alexrp alexrp modified the milestones: v4.2, v5.0 Jan 4, 2024
@alexrp
Copy link
Member Author

alexrp commented Apr 25, 2024

Basically just need to move most of the logic to generate command line arguments from GenerateCommandLineCommands() to GenerateResponseFileCommands() and MSBuild will take care of the rest. There are a few arguments that we want to keep in GenerateCommandLineCommands(), such as the verb (cc, c++, etc) and -fdiagnostics-format=msvc.

@alexrp
Copy link
Member Author

alexrp commented Jul 10, 2024 

         ld.lld : error : cannot open -target: No such file or directory [/home/alexrp/Source/vezel-dev/zig-sdk/src/samples/cexe/cexe.cproj]
         ld.lld : error : cannot open arm-linux.3.10-gnueabihf.2.17: No such file or directory [/home/alexrp/Source/vezel-dev/zig-sdk/src/samples/cexe/cexe.cproj]

The process is being invoked as zig cc -fdiagnostics-format=msvc @/path/to/flags.rsp as expected. The response file contains the flags as expected. It works fine in a normal shell. Super confused about this, honestly.

@alexrp alexrp modified the milestones: v5.0, Future Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexrp alexrp

Labels
area: tasks Issues related to MSBuild tasks. state: approved Enhancements and tasks that have been approved.
Milestone
Future
Development

No branches or pull requests
1 participant
@alexrp