Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary update-search-index processes for unchanged items #525

Open
janreges opened this issue Jun 27, 2023 · 0 comments
Open

Unnecessary update-search-index processes for unchanged items #525

janreges opened this issue Jun 27, 2023 · 0 comments

Comments

@janreges
Copy link

Describe the bug

Hi,

Apparently, the SuperTable plugin does not detect whether there was any text change when saving existing items and generates update-search-index processes for all items, which can be hundreds or thousands of unnecessary processes.

For example - we used SuperTable for a simple translation solution for our frontend, which runs in Astro (via GraphQL).

We have hundreds of these items there, and even editing one word will generate hundreds of processes to update the search-index.

image

Steps to reproduce

  1. Create simple supertable field with 2 fields/columns
  2. Put 100 rows into this table
  3. Even if you later edit only one text item in this table and save it, the plugin will generate an update-search-index process for all, even unchanged, items.

The expected behavior is that when saving, it is detected whether the value has changed (e.g. based on affected rows after the UPDATE query has been executed) and if not, the searchindex update process will not be invoked unnecessarily.

Thanks for improving this behavior.

Craft CMS version

4.4.14

Plugin version

3.0.9

Multi-site?

Yes

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant