Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements Based on Feedback from 4/19/23 #16

Open
11 tasks done
venuswku opened this issue Apr 20, 2023 · 0 comments
Open
11 tasks done

Improvements Based on Feedback from 4/19/23 #16

venuswku opened this issue Apr 20, 2023 · 0 comments

Comments

@venuswku
Copy link
Owner

venuswku commented Apr 20, 2023

  1. Fix downloaded time-series CSV file.
    • use NaN for unavailable values (4/20/23)
    • rename app as "Elwha Topo-Bathy Viewer" (4/20/23)
  2. Document how to restructure code for a new dataset.
    • separate customized time period and data category widgets for Elwha collection (4/25/23)
    • refactor classes to contain reusable widgets for any inputted dataset (4/26/23)
    • dedicate a Wiki page for how to view a new dataset with the app (4/27/23 & 4/28/23)
  3. Get app ready for Dan to share a demo with Peter.
    • use Panel's admin profiler to get a rough estimate of required RAM, memory, cores, etc. in order to run app (4/21/23)
      • max 1GB of memory/RAM
      • max 10% CPU
    • fix failing MyBinder build (4/19/23 & 4/21/23 & 4/24/23)
      • data isn't appearing on map though
    • try deploying app with Heroku or Google Colab (4/28/23)
      • got a working app with Heroku’s Container Registry, but it requires $7/month to deploy our Docker container as a Heroku dyno
    • try using Docker to avoid users from getting dependency conflicts on different machines when creating their conda environment (most of May)
      • successfully build a Docker image
        • use Dockerfile and .dockerignore as build context
        • fix bugs that arose from dependencies (e.g HoloViews, GeoViews, Panel) updating
      • run Docker image in a Docker container locally with Docker Desktop
      • wait for Peter to implement Docker in CMGDS server
  4. Raise several issues on GitHub.
    • update GeoViews to be compatible with Bokeh 3.1.0 in order to allow customizing number of columns in plot legends (4/19/23)
      • wait for HoloViews 1.16.0 to be released
      • PR for legend_cols update was recently merged this past Monday
    • Bokeh legends disappear completely with more than 12 items (4/20/23)
      • don't need to write issue!
      • just set legend_limit option >= number of overlaid point and curve plots (default limit was 25 glyphs/plots)
      • (optional) ask how to display more than one value dimension in DataShader's hover tooltip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant