Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring REDUCE #43

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Refactoring REDUCE #43

merged 5 commits into from
Nov 27, 2023

Conversation

valebes
Copy link
Owner

@valebes valebes commented Nov 15, 2023 •
edited
Loading

Refactoring reduce operator on both Pipeline and Threadpool interface.

  • Create new par_reduce() in thread pool interface.
  • Fix docs and examples.
  • Update README.MD
  • Change old par_reduce() to map_by_key().
  • Change par_map_reduce() in order to use the new par_reduce() method.
  • Change MapReduce and Reduce templates in order to use the new par_reduce() method.
  • Improve docs

@valebes valebes self-assigned this Nov 15, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7e07d3a) 76.98% compared to head (ac70eef) 77.23%.

Files Patch % Lines
src/thread_pool/mod.rs 90.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   76.98%   77.23%   +0.24%     
==========================================
  Files          13       13              
  Lines        1182     1208      +26     
==========================================
+ Hits          910      933      +23     
- Misses        272      275       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valebes valebes requested a review from Della97 November 27, 2023 14:47
@valebes valebes marked this pull request as ready for review November 27, 2023 14:47
Della97
Della97 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@Della97 Della97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@valebes valebes merged commit 176737f into main Nov 27, 2023
4 checks passed
@valebes valebes deleted the reduce branch November 27, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Della97 Della97 Della97 approved these changes

Assignees

@valebes valebes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valebes @Della97