Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Executor saved as string instead NULL (when duplicating prevent opening preset for instance) #13

Open
Yivan opened this issue Sep 30, 2021 · 1 comment

Comments

@Yivan
Copy link

Yivan commented Sep 30, 2021

Hello,

Using the "Duplicate" feature:

image

Try duplicate the same one 2 or 3 times. When opening previous one this send a:

image

Timestamp: Thu Sep 30 2021 21:54:44 GMT+0200 (heure d’été d’Europe centrale)
Status: 500 | 
URL: /admin/elementsexporttoolkit/config/get
Message: Class "" not found
Trace: 
in /var/www/html/vendor/elements/export-toolkit-bundle/src/Controller/ConfigController.php:272
#0 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(156): Elements\Bundle\ExportToolkitBundle\Controller\ConfigController->getAction()
#1 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(78): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#2 /var/www/html/vendor/symfony/http-kernel/Kernel.php(199): Symfony\Component\HttpKernel\HttpKernel->handle()
#3 /var/www/html/public/index.php(36): Symfony\Component\HttpKernel\Kernel->handle()
#4 {main}

And today I get the same message on a preset which was working fine before.

I digged in the code and it seems this is the executor which is saved as "executor" => "", in the export-toolkit-configurations.php. Replacing in this config by manually edit the php file by "executor" => NULL, make it works.

I think this field should be saved as NULL if empty in the GUI, or the line here https://github.com/elements-at/ExportToolkit/blob/master/src/Controller/ConfigController.php#L269 should check for empty too.

Thanks.

@Yivan
Copy link
Author

Yivan commented Sep 30, 2021

I just saw there is already a PR fixing this: #12
Please merge it and release a new version with this fix, it would be great.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant