New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the paper-ripple hack #24

Closed

platosha opened this issue Feb 10, 2016 · 1 comment

Contributor

platosha commented Feb 10, 2016

There’s a monkey patch in vaadin-upload for paper-ripple internal radius calculation. The purpose of the monkey path is

to remove the Ripple.MAX_RADIUS limit (which is not customisable),
to have a little nicer animation formula for large container ripples that we have.

We need to remove this hack when paper-ripple would expose the maxRadius property.

See:

issue for exposing Ripple.MAX_RADIUS in the paper-ripple repo: Expose MAX_RADIUS to public API PolymerElements/paper-ripple#27
paper-ripple rewrite PR: Initial import of new ripple code. PolymerElements/paper-ripple#63
And

The text was updated successfully, but these errors were encountered:

Member

tomivirkki commented May 14, 2018

The latest version no longer uses MD/Paper. Closing.

tomivirkki closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment