Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with Three.js 170 #58

Open
Romaixn opened this issue Nov 1, 2024 · 4 comments
Open

Error with Three.js 170 #58

Romaixn opened this issue Nov 1, 2024 · 4 comments

Comments

@Romaixn
Copy link

Romaixn commented Nov 1, 2024

Hi! After upgrading to Three.js 170, I got this error in console:

Uncaught TypeError: source is undefined
    expandShaderIncludes troika-three-utils.esm.js:22
    upgradeShaders troika-three-utils.esm.js:347
    onBeforeCompile troika-three-utils.esm.js:168
    getProgram three.module.js:30552
    setProgram three.module.js:30817
    renderBufferDirect three.module.js:29615
    renderObject three.module.js:30492
    renderObjects three.module.js:30461
    renderScene three.module.js:30312
    render three.module.js:30128
    updateR3FPerf Graph.tsx:210
    render$1 events-321b05fb.esm.js:1541
    loop events-321b05fb.esm.js:1570
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
    loop events-321b05fb.esm.js:1556
troika-three-utils.esm.js:22:2

@FarazzShaikh
Copy link

I believe this is because of this

mrdoob/three.js@ac963e2#r148635345

it is a bug in troika-three-utils ultimately

@RenaudRohlinger
Copy link
Member

Submitted a PR to fix an issue in Three.js:
mrdoob/three.js#29789

@lojjic
Copy link

lojjic commented Nov 2, 2024

FYI it's fixed / worked-around in troika-three-text/utils 0.50.3.

Thank you for the analysis @FarazzShaikh

@FarazzShaikh
Copy link

They’re reverting the breaking change in the next patch I believe. So we’ll need to revert the workaround in our libraries as well 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants